Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves missing exports condition #22 #23

Merged
merged 2 commits into from
May 15, 2024
Merged

Resolves missing exports condition #22 #23

merged 2 commits into from
May 15, 2024

Conversation

RealSocius
Copy link
Contributor

@RealSocius RealSocius commented May 10, 2024 •
edited
Loading

Fixes #22 "WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte."

metonym
metonym approved these changes May 15, 2024
View reviewed changes
Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

A couple of notes:

  • Preserving the svelte condition for backward-compatibility
  • Exports map must also include paths to TypeScript definitions
  • Exports map must also map subfolders (direct imports)

@metonym metonym merged commit 6bbc332 into metonym:master May 15, 2024
1 check passed
metonym pushed a commit that referenced this pull request May 15, 2024
@RealSocius @metonym
fix(package): add exports map (#23)
4a95e47 
Fixes  #22
@metonym
Copy link
Owner

metonym commented May 15, 2024

Thanks – fixed in v2.2.1

@jneuendorf-i4h jneuendorf-i4h mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing exports condition
2 participants
@RealSocius @metonym