Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: 2.3.0 #2790

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Prepare release: 2.3.0 #2790

merged 4 commits into from
Jun 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2024

⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡

This PR was created by the Release stage 1 - create release PR (Rose 2+ only) workflow, triggered by @oliver-sanders

Tests:

  • Tests last run on master:
    test.yml
  • ✔️ Build check passed - see the workflow run (number 19) for more info

Checklist:

  • Milestone complete?
    0 other open issues/PRs on milestone 2.3.0 at time of PR creation
  • Changelog up-to-date?
    • Examine pull requests made since the last release
    • "Released on" date updated? ✔️ 2024-06-18

Next steps:

  • @oliver-sanders should request 1 or 2 reviews
  • If any further changes are needed, push to this PR branch
  • After merging, the bot will comment below with a link to the release (if not, look at the PR checks tab)

Important

Do not use [skip ci] in commit messages pushed to this PR, as it will prevent the 2nd stage release workflow from running.

Workflow: Release stage 1 - create release PR (Rose 2+ only), run: 19
@github-actions github-actions bot added this to the 2.3.0 milestone Jun 18, 2024
@github-actions github-actions bot added the release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish. label Jun 18, 2024
@oliver-sanders
Copy link
Member

Mac OS tests currently broken (#2787), all other tests passed.

CHANGES.md Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders requested a review from MetRonnie June 18, 2024 13:00
CHANGES.md Show resolved Hide resolved
Co-authored-by: Ronnie Dutta <[email protected]>
@oliver-sanders
Copy link
Member

(mac os test failing with expected DNS issues)

CHANGES.md Show resolved Hide resolved
@MetRonnie MetRonnie merged commit 2e709dc into master Jun 18, 2024
1 check passed
@MetRonnie MetRonnie deleted the prepare-2.3.0 branch June 18, 2024 14:12
@github-actions github-actions bot changed the title Prepare release: 2.3.0 [failure] Prepare release: 2.3.0 Jun 18, 2024
Copy link
Contributor Author

failure

Check the run

Revert the release commit and rerun the release process to retry.

Alternatively you can still publish the dist to PyPI manually:

(Make sure you have commit 2e709dce15ba42dcf8fc751414c7a3af3eb487eb checked out)

# Create the build (old style for setup.py projects)
python3 setup.py bdist_wheel sdist

# Create the build (PEP517)
python -m build

# Upload your build to PyPI
twine upload dist/*

Then create a GitHub release (this link pre-populates the tag and target fields).


Comment created by workflow: Release stage 2 - auto publish, run: 33

@MetRonnie
Copy link
Contributor

Will try re-running the workflow in a few mins

This comment was marked as resolved.

@MetRonnie
Copy link
Contributor

Actually it did work: https://pypi.org/project/metomi-rose/2.3.0/

@oliver-sanders
Copy link
Member

Some internal server error the first time appears to have masked the successful upload?

@MetRonnie
Copy link
Contributor

MetRonnie commented Jun 18, 2024

Presumably. I've created the GH release manually

@MetRonnie MetRonnie changed the title [failure] Prepare release: 2.3.0 Prepare release: 2.3.0 Jun 18, 2024
@wxtim
Copy link
Contributor

wxtim commented Jun 18, 2024

I've double checked that I can install it from PyPi, although I can't imagine I wouldn't be able to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants