First draft of new climatology config #1356
Conversation
|
Two tests fail due to different mean obs than expected with new climatology. |
I remember climatology previously was hard coded, in the pyaerocom const to be defined as the mean between 2005- 2015, so if you use different period it might cause the test failing. The calc_climatology function in helpers.py will set the year of the climatology unless defined (the |
|
|
||
| resample_how: str = const.CLIM_RESAMPLE_HOW | ||
| freq: str = const.CLIM_FREQ | ||
| mincount: dict = const.CLIM_MIN_COUNT |
There was a problem hiding this comment.
I think set_year should also be an attribute here, or if you have a better solution?
| stop=use_climatology_ref.stop, | ||
| clim_mincount=use_climatology_ref.mincount, | ||
| resample_how=use_climatology_ref.resample_how, | ||
| clim_freq=use_climatology_ref.freq, |
There was a problem hiding this comment.
Same here set_year should be set
| freq: str = const.CLIM_FREQ | ||
| mincount: dict = const.CLIM_MIN_COUNT | ||
|
|
||
| @field_validator("resample_how") |
There was a problem hiding this comment.
Don't need a validator for this. Instead
resample_how: Literal["mean", "median"] = const.CLIM_RESAMPLE_HOW
assuming const.CLIM_RESAMPLE_HOW is either "mean" or "median"
Change Summary
Adds new way of defining how the climatology is defined. Instead of just a bool to turn climatology off and on, a climatology config can now be passed into the colocation setup.
This is a reimplementation of @Ovewh 's PR #1135. As pyaercom has changed as much as it has, it was easier to do everything from scratch.
Related issue number
Aims to fix #1125
Checklist