-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of http://ionicframework.com/docs/api/directive/ionList/ #368
Open
JoeyAndres
wants to merge
64
commits into
meteoric:master
Choose a base branch
from
meteoric124:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, ionSlideBox inside ionSideMenu. If developer still wants the propagation, simply pass stopPropagation=false to ionSlideBox.
JoeyAndres
changed the title
Fix the event propagation when there are nested draggable items.
Implementation of http://ionicframework.com/docs/api/directive/ionList/
Jan 25, 2016
at least one of ionOptions or ionDelete or ionReorder children. - That being said, one can now have ionOptions and swipe to left to show them. - One can now display ionDelete by setting ionItem's showDelete=true and giving ionDelete as its children. - Reorder also works by setting showReorder in ionItem=true and ionReorder is given as ionItem's children. Misc: - I forked Snap.js and integrated PEP (pointer event polyfill) that is supposed to abstract away from mouse and touch event. Making the interface much more consistent.
JoeyAndres
force-pushed
the
master
branch
14 times, most recently
from
February 7, 2016 09:39
6be8fbc
to
cffe37e
Compare
original controlelr. Only lib/utility.js is kept for transition purposes.
copy of the original ionic components.
Sidemenu now worked, but still need to be integrated properly, i.e. exposing openLeft, ...
trying to set a reactivevar by itself.
- Note: slidebox have no controller atm. - listController now have the pattern for converting angular controller to meteor. 1. For each dependency, make them native or at least Meteor friendly. 2. If there is a dependncy on dom element, e.g. requires a "el" at scope wrap the constractor with init This is because Meteor have no concept of "prelink" like angular. 3. meteor-template-extension now added a scope property for all such that the child scope have access to parent scope by setting scope.__proto__ of the child. 4. Pass the scope to the controller at onCreated. 5. jqlite => $ 6. $scope.$on => $(scope).on 7. $scope.$watch to tracker.autorun(c => ... 8. And other stuff.... - ionList is now using original controllers.
to 4.0.5, concept of scope.
…e to not propagate up
of converting angular to native or at least meteor friendly. Accumulated through last few commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have managed to implement ionList complex features:
This have became my personal project for the past few days, and reading that this place is maintained, didn't bother to create a branch to isoloate my README.md and such. I realized that this might be an important for some people, who can deny an eye candy, thus here it is.