This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 364
Blaze update to 1.10.2 and update flow router to ostrio:flow-router-extra #280
Open
vparpoil
wants to merge
3
commits into
meteor:master
Choose a base branch
from
vparpoil:update-flow-router
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
|
||
# meteor libraries | ||
[email protected] | ||
ecmascript@0.11.0 | ||
ecmascript@0.14.3 | ||
[email protected] | ||
[email protected] | ||
[email protected] | ||
|
@@ -18,13 +18,13 @@ [email protected] | |
|
||
# ui | ||
[email protected] | ||
reactive-dict@1.2.0 | ||
reactive-dict@1.3.0 | ||
[email protected] | ||
aldeed:template-extension | ||
percolate:momentum | ||
|
||
# data | ||
mongo@1.5.0 | ||
mongo@1.10.0 | ||
aldeed:simple-schema | ||
aldeed:collection2 | ||
dburles:collection-helpers | ||
|
@@ -33,29 +33,27 @@ mdg:validated-method | |
mdg:validation-error | ||
|
||
# routing | ||
kadira:flow-router | ||
kadira:blaze-layout | ||
arillo:flow-router-helpers | ||
zimme:active-route | ||
ostrio:flow-router-extra | ||
|
||
# i18n | ||
tap:i18n | ||
|
||
# accounts | ||
accounts-password@1.5.1 | ||
accounts-password@1.6.0 | ||
useraccounts:core | ||
useraccounts:unstyled | ||
useraccounts:flow-routing | ||
mealsunite:flow-routing-extra # useraccounts routes for flow-routing-extra | ||
kadira:blaze-layout # needed by mealsunite:flow-routing-extra | ||
softwarerero:accounts-t9n | ||
|
||
# mobile | ||
[email protected] | ||
mobile-experience@1.0.5 | ||
mobile-experience@1.1.0 | ||
chriswessels:hammer | ||
|
||
# production | ||
juliancwirko:postcss | ||
standard-minifier-js@2.3.4 | ||
standard-minifier-js@2.6.0 | ||
[email protected] | ||
app-prod-security | ||
|
||
|
@@ -70,9 +68,9 @@ practicalmeteor:sinon | |
meteortesting:mocha | ||
hwillson:stub-collections | ||
johanbrook:publication-collector | ||
shell-server@0.3.1 | ||
shell-server@0.5.0 | ||
dburles:factory | ||
|
||
# security | ||
[email protected] | ||
dynamic-import@0.4.0 | ||
dynamic-import@0.5.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
METEOR@1.7.0.1 | ||
METEOR@1.10.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import { FlowRouter } from 'meteor/kadira:flow-router'; | ||
import { BlazeLayout } from 'meteor/kadira:blaze-layout'; | ||
import { FlowRouter } from 'meteor/ostrio:flow-router-extra'; | ||
|
||
// Import to load these templates | ||
import '../../ui/layouts/app-body.js'; | ||
|
@@ -13,20 +12,21 @@ import '../../ui/accounts/accounts-templates.js'; | |
FlowRouter.route('/lists/:_id', { | ||
name: 'Lists.show', | ||
action() { | ||
BlazeLayout.render('App_body', { main: 'Lists_show_page' }); | ||
this.render('App_body', { main: 'Lists_show_page' }); | ||
}, | ||
}); | ||
|
||
FlowRouter.route('/', { | ||
name: 'App.home', | ||
action() { | ||
BlazeLayout.render('App_body', { main: 'app_rootRedirector' }); | ||
this.render('App_body', { main: 'app_rootRedirector' }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this.render('App_body', 'app_rootRedirector'); |
||
}, | ||
}); | ||
|
||
// the App_notFound template is used for unknown routes and missing lists | ||
FlowRouter.notFound = { | ||
FlowRouter.route('*', { | ||
name: "NotFound", | ||
action() { | ||
BlazeLayout.render('App_body', { main: 'App_notFound' }); | ||
this.render('App_body', { main: 'App_notFound' }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this.render('App_body', 'App_notFound'); |
||
}, | ||
}; | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,7 @@ import { Meteor } from 'meteor/meteor'; | |
import { ReactiveVar } from 'meteor/reactive-var'; | ||
import { ReactiveDict } from 'meteor/reactive-dict'; | ||
import { Template } from 'meteor/templating'; | ||
import { ActiveRoute } from 'meteor/zimme:active-route'; | ||
import { FlowRouter } from 'meteor/kadira:flow-router'; | ||
import { FlowRouter } from 'meteor/ostrio:flow-router-extra'; | ||
import { TAPi18n } from 'meteor/tap:i18n'; | ||
import { T9n } from 'meteor/softwarerero:accounts-t9n'; | ||
import { _ } from 'meteor/underscore'; | ||
|
@@ -69,7 +68,7 @@ Template.App_body.helpers({ | |
] }); | ||
}, | ||
activeListClass(list) { | ||
const active = ActiveRoute.name('Lists.show') | ||
const active = FlowRouter.current().route.name === 'Lists.show' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. import { FlowRouter , RouterHelpers } from 'meteor/ostrio:flow-router-extra';
RouterHelpers.name('Lists.show'); |
||
&& FlowRouter.getParam('_id') === list._id; | ||
|
||
return active && 'active'; | ||
|
@@ -121,7 +120,7 @@ Template.App_body.events({ | |
Meteor.logout(); | ||
|
||
// if we are on a private list, we'll need to go to a public one | ||
if (ActiveRoute.name('Lists.show')) { | ||
if (FlowRouter.current().route.name === 'Lists.show') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. import { FlowRouter , RouterHelpers } from 'meteor/ostrio:flow-router-extra';
RouterHelpers.name('Lists.show'); |
||
// TODO -- test this code path | ||
const list = Lists.findOne(FlowRouter.getParam('_id')); | ||
if (list.userId) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.