-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #230
Code cleanup #230
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
359f822
to
3eee189
Compare
06c4a80
to
2f1a93c
Compare
…ng implementation classes.
…mplexity around command authoring a great deal.
…ance. The first was that the module was not being loaded for constraint validation due to the load happening inside the disabled schema validation block. The second was a tricky issue on loading the module, where some definitions were mistaken found to be inline, when they had separate definition classes.
2f1a93c
to
431d3c4
Compare
...c/main/java/gov/nist/secauto/metaschema/cli/processor/command/CommandExecutionException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/gov/nist/secauto/metaschema/core/util/DeleteOnShutdown.java
Show resolved
Hide resolved
databind/src/main/java/gov/nist/secauto/metaschema/databind/io/xml/MetaschemaXmlReader.java
Outdated
Show resolved
Hide resolved
...schema-cli/src/main/java/gov/nist/secauto/metaschema/cli/commands/ValidateModuleCommand.java
Show resolved
Hide resolved
…ocessor/command/CommandExecutionException.java
039670e
into
metaschema-framework:develop
* Code cleanup and addressed a bunch of PMD, Spotbugs, and compiler warnings. * Added Javadocs to many classes. * Refactored XML data type parsing implementation classes to hide some implementation details and to use a more sensible package organization. * Refactored CLI commands to use more shared code. This reduces the complexity around command authoring a great deal. * Fixed multiple bugs causing an issues around validating a content instance. The first was that the module was not being loaded for constraint validation due to the load happening inside the disabled schema validation block. The second was a tricky issue on loading the module, where some definitions were mistaken found to be inline, when they had separate definition classes. These issues were exposed by prior work on metaschema-framework#211.
Committer Notes
Code cleanup and addressing PMD and Spotbug warnings.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: