Skip to content

Commit

Permalink
Merge pull request #258 from metanorma/fix/annotation
Browse files Browse the repository at this point in the history
  • Loading branch information
Intelligent2013 authored Jul 3, 2024
2 parents f460c61 + d6c7bc1 commit e35421b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SHELL ?= /bin/bash
endif

#JAR_VERSION := $(shell mvn -q -Dexec.executable="echo" -Dexec.args='$${project.version}' --non-recursive exec:exec -DforceStdout)
JAR_VERSION := 1.94
JAR_VERSION := 1.95
JAR_FILE := mn2pdf-$(JAR_VERSION).jar

all: target/$(JAR_FILE)
Expand Down
10 changes: 5 additions & 5 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ You will need the Java Development Kit (JDK) version 8, Update 241 (8u241) or hi

[source,sh]
----
java -Xss5m -Xmx2048m -jar target/mn2pdf-1.94.jar --xml-file <XML-FileName> --xsl-file <XSLT-FileName> --pdf-file <Output-PDF-FileName> [--syntax-highlight]
java -Xss5m -Xmx2048m -jar target/mn2pdf-1.95.jar --xml-file <XML-FileName> --xsl-file <XSLT-FileName> --pdf-file <Output-PDF-FileName> [--syntax-highlight]
----

e.g.

[source,sh]
----
java -Xss5m -Xmx2048m -jar target/mn2pdf-1.94.jar --xml-file tests/G.191.xml --xsl-file tests/itu.recommendation.xsl --pdf-file tests/G.191.pdf
java -Xss5m -Xmx2048m -jar target/mn2pdf-1.95.jar --xml-file tests/G.191.xml --xsl-file tests/itu.recommendation.xsl --pdf-file tests/G.191.pdf
----

=== PDF encryption features
Expand Down Expand Up @@ -100,7 +100,7 @@ Update version in `pom.xml`, e.g.:
----
<groupId>org.metanorma.fop</groupId>
<artifactId>mn2pdf</artifactId>
<version>1.94</version>
<version>1.95</version>
<name>Metanorma XML to PDF converter</name>
----

Expand All @@ -111,8 +111,8 @@ Tag the same version in Git:

[source,xml]
----
git tag v1.94
git push origin v1.94
git tag v1.95
git push origin v1.95
----

Then the corresponding GitHub release will be automatically created at:
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.metanorma.fop</groupId>
<artifactId>mn2pdf</artifactId>
<version>1.94</version>
<version>1.95</version>
<name>Metanorma XML to PDF converter</name>
<packaging>jar</packaging>
<url>https://www.metanorma.org</url>
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/org/metanorma/fop/PDFGenerator.java
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,8 @@ private void runFOP (fontConfig fontcfg, Source src, File pdf) throws IOExceptio
String methodName = getClass().getSimpleName() + "." + (new Object(){}.getClass().getEnclosingMethod().getName());
Profiler.addMethodCall(methodName);

PDFUA_error = false;

OutputStream out = null;
String xmlIF = null;
long startMethodTime = System.currentTimeMillis();
Expand Down Expand Up @@ -650,7 +652,7 @@ private void runFOP (fontConfig fontcfg, Source src, File pdf) throws IOExceptio



if (isAddAnnotations) {
if (isAddAnnotations && PDFUA_error == false) {
logger.log(Level.INFO, "[INFO] Annotation processing...");
try {

Expand All @@ -665,7 +667,7 @@ private void runFOP (fontConfig fontcfg, Source src, File pdf) throws IOExceptio
Annotation annotations = new Annotation();
annotations.process(pdf, xml_review);
} catch (Exception ex) {
logger.severe("Can't add annotation.");
logger.severe("Can't add annotation (" + ex.toString() + ").");
ex.printStackTrace();
}
}
Expand Down

0 comments on commit e35421b

Please sign in to comment.