Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapsible figure and sourcecode in HTML: https://github.com/metanor… #709

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

opoudjis
Copy link
Contributor

…ma/metanorma-ogc/issues/331

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Aug 16, 2024
encoding: "UTF-8")
"#{a[0]}#{scripts}#{a[1]}"
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

@@ -424,7 +424,7 @@ p.Biblio, p.NormRef {

/* Blocks */

.SourceTitle {
.SourceTitle, .FigureTitle {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each selector in a comma sequence should be on its own single line
Selector FigureTitle should be written in lowercase with hyphens
Selector SourceTitle should be written in lowercase with hyphens

OUTPUT
IsoDoc::Ogc::HtmlConvert.new({ filename: "test" })
.convert("test", presxml, false)
xml = Nokogiri::XML(File.read("test.html"))
xml = xml.at("//div[@id = 'A']")
expect(Xml::C14n.format(strip_guid(xml.to_xml)))
.to be_equivalent_to Xml::C14n.format(html)
expect(Xml::C14n.format(strip_guid(xml.to_xml))).to be_equivalent_to Xml::C14n.format(html)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [95/80]

@opoudjis opoudjis merged commit 51ea53c into main Sep 9, 2024
18 of 20 checks passed
@opoudjis opoudjis deleted the fix/collapse-snippets branch September 9, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant