Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound UPDATED_REPO error on dev env tests #704

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix unbound UPDATED_REPO error on dev env tests #704

merged 1 commit into from
Apr 30, 2024

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Apr 18, 2024 •
edited
Loading

Fix dev env integration tests

@Sunnatillo
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@Sunnatillo
Copy link
Member Author

/test

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test dev-env-integration-test-centos-main
  • /test dev-env-integration-test-centos-release-1-4
  • /test dev-env-integration-test-centos-release-1-5
  • /test dev-env-integration-test-centos-release-1-6
  • /test dev-env-integration-test-ubuntu-main
  • /test dev-env-integration-test-ubuntu-release-1-4
  • /test dev-env-integration-test-ubuntu-release-1-5
  • /test dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-feature-test-release-1-4
  • /test metal3-centos-e2e-feature-test-release-1-5
  • /test metal3-centos-e2e-feature-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-4
  • /test metal3-centos-e2e-integration-test-release-1-5
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-4
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-5
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-6
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-4
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-5
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-6
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-4
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-5
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-0-5
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-3
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-4
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-5
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-release-1-4
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-release-1-5
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-release-1-6
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-release-1-4
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-release-1-5
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-release-1-6
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-release-1-4
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-release-1-5
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-keep-e2e-clusterctl-upgrade-test-main
  • /test metal3-keep-e2e-clusterctl-upgrade-test-release-0-5
  • /test metal3-keep-e2e-clusterctl-upgrade-test-release-1-3
  • /test metal3-keep-e2e-clusterctl-upgrade-test-release-1-4
  • /test metal3-keep-e2e-clusterctl-upgrade-test-release-1-5
  • /test metal3-keep-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-feature-test-release-1-4
  • /test metal3-ubuntu-e2e-feature-test-release-1-5
  • /test metal3-ubuntu-e2e-feature-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-release-1-4
  • /test metal3-ubuntu-e2e-integration-test-release-1-5
  • /test metal3-ubuntu-e2e-integration-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

1 similar comment
@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

@Sunnatillo Sunnatillo changed the title Fix UPDATED_REPO unbound var error on dev env tests Fix unbound UPDATED_REPO error on dev env tests Apr 18, 2024
@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Apr 18, 2024 •
edited
Loading

part of #705

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

1 similar comment
@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-centos-main

@Sunnatillo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@Sunnatillo
Copy link
Member Author

/assign @kashifest @mboukhalfa

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-centos-main

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main

@Sunnatillo
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: Sunnatillo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smoshiur1237
smoshiur1237 reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2024
@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main
/test dev-env-integration-test-centos-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-7
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test dev-env-integration-test-centos-release-1-5
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-feature-test-release-1-5
  • /test metal3-centos-e2e-feature-test-release-1-6
  • /test metal3-centos-e2e-feature-test-release-1-7
  • /test metal3-centos-e2e-integration-test-release-1-5
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-5
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-6
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-7
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-5
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-6
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-7
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-5
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-5
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-feature-test-release-1-5
  • /test metal3-ubuntu-e2e-feature-test-release-1-6
  • /test metal3-ubuntu-e2e-feature-test-release-1-7
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-5
  • /test metal3-ubuntu-e2e-integration-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config
  • shellcheck

In response to this:

/test dev-env-integration-test-ubuntu-main
/test dev-env-integration-test-centos-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@tuminoid
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-release-1-7
this is marked as requird in config, so I'll run it once so I can add it to GH side too

@Sunnatillo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-release-1-7

@Sunnatillo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-ubuntu-main
/test dev-env-integration-test-centos-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-7
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test dev-env-integration-test-centos-release-1-5
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-feature-test-release-1-5
  • /test metal3-centos-e2e-feature-test-release-1-6
  • /test metal3-centos-e2e-feature-test-release-1-7
  • /test metal3-centos-e2e-integration-test-release-1-5
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-5
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-6
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-7
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-5
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-6
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-7
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-5
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-5
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-feature-test-release-1-5
  • /test metal3-ubuntu-e2e-feature-test-release-1-6
  • /test metal3-ubuntu-e2e-feature-test-release-1-7
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-5
  • /test metal3-ubuntu-e2e-integration-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config
  • shellcheck

In response to this:

/test dev-env-integration-test-ubuntu-main
/test dev-env-integration-test-centos-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo
Copy link
Member Author

/test dev-env-integration-test-centos-release-1-5

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Apr 25, 2024 •
edited
Loading

@Sunnatillo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
dev-env-integration-test-centos-release-1-5 d879c98 link false /test dev-env-integration-test-centos-release-1-5
metal3-ubuntu-e2e-integration-test-release-1-7 d879c98 link true /test metal3-ubuntu-e2e-integration-test-release-1-7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Sunnatillo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

smoshiur1237
smoshiur1237 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit afe3f7e into metal3-io:main Apr 30, 2024
6 checks passed
@Sunnatillo Sunnatillo deleted the fix-unbound-var/sunnat branch April 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@mboukhalfa mboukhalfa mboukhalfa approved these changes

Assignees

@mboukhalfa mboukhalfa

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sunnatillo @metal3-io-bot @tuminoid @mboukhalfa @smoshiur1237 @kashifest