Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Peppi-lotta and Huy as reviewers #2268

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #2266

/assign tuminoid

/cherrypick release-1.8 release-1.7

Both Peppi-lotta and Huy has reached the required number of commits and also helped in the review process recently. Thanks a lot folks for your contributions.
Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.9 milestone Jan 23, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 🌱 Add Peppi-lotta and Huy as reviewers
/approve
/lgtm

@metal3-io-bot metal3-io-bot changed the title [release-1.9] 🌱 Add Peppi-lotta and Huy as reviewers 🌱 Add Peppi-lotta and Huy as reviewers Jan 23, 2025
@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-9

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-9

In response to this:

/override metal3-centos-e2e-integration-test-release-1-9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 08195ec into metal3-io:release-1.9 Jan 23, 2025
13 checks passed
@metal3-io-bot
Copy link
Contributor Author

@metal3-io-bot: new pull request could not be created: failed to create pull request against metal3-io/cluster-api-provider-metal3#release-1.8 from head metal3-io-bot:cherry-pick-2268-to-release-1.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between metal3-io:release-1.8 and metal3-io-bot:cherry-pick-2268-to-release-1.8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

This is an automated cherry-pick of #2266

/assign tuminoid

/cherrypick release-1.8 release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants