Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update clusterctl tests for 1.9 #2242

Merged
merged 1 commit into from
Jan 20, 2025
Merged

🌱 Update clusterctl tests for 1.9 #2242

merged 1 commit into from
Jan 20, 2025

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Jan 14, 2025 •
edited
Loading

What this PR does / why we need it:
Update clusterctl tests for 1.9. and minor refactoring.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2241

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2025
@adilGhaffarDev adilGhaffarDev mentioned this pull request Jan 14, 2025
Closed
48 tasks
@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from 6f6cb9f to 35c4203 Compare January 14, 2025 09:58
@adilGhaffarDev adilGhaffarDev mentioned this pull request Jan 14, 2025
Closed
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from 35c4203 to c8bb16d Compare January 14, 2025 11:02
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from c8bb16d to 8a1822c Compare January 14, 2025 11:17
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

tuminoid
tuminoid reviewed Jan 14, 2025
View reviewed changes
scripts/ci-e2e.sh Outdated
@@ -98,11 +98,13 @@ source "${M3_DEV_ENV_PATH}/lib/ironic_tls_setup.sh"
BMO_OVERLAYS=(
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 0.6 be removed if we remove 1.7 ?

scripts/ci-e2e.sh Outdated Show resolved Hide resolved
@adilGhaffarDev
Update clusterctl tests for 1.9
9146b4b 
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from 8a1822c to 9146b4b Compare January 14, 2025 15:13
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2025
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@mquhuy
Copy link
Member

mquhuy commented Jan 16, 2025

/retest

@tuminoid
Copy link
Member

/retest
CI should be better now.

@Rozzii
Copy link
Member

Rozzii commented Jan 20, 2025

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii January 20, 2025 08:33
tuminoid
tuminoid reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Good improvements, makes it clearer what we're actually testing.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
Rozzii
Rozzii reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@metal3-io-bot metal3-io-bot merged commit c9d6f72 into metal3-io:main Jan 20, 2025
18 checks passed
@metal3-io-bot metal3-io-bot deleted the update-clusterctl-test-1.9/adil branch January 20, 2025 10:54
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Jan 20, 2025
@Rozzii Rozzii mentioned this pull request Jan 24, 2025
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.10
Development

Successfully merging this pull request may close these issues.

BMO 0.9 and Ironic 27.0 are missing from CAPM3 e2e overlays
5 participants
@adilGhaffarDev @tuminoid @mquhuy @Rozzii @metal3-io-bot