Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Merge all sql files into one #252

Closed
wants to merge 3 commits into from

Conversation

Alva8756
Copy link
Contributor

@Alva8756 Alva8756 commented Dec 8, 2023

This is the copy of metal-toolbox/fleetdb#4 for verifying PR Linting and Test / lint-and-test (pull_request)

@Alva8756 Alva8756 requested a review from a team as a code owner December 8, 2023 07:10
@Alva8756 Alva8756 closed this Dec 8, 2023
@Alva8756 Alva8756 reopened this Dec 10, 2023
@Alva8756
Copy link
Contributor Author

I realized we don't have Linting and Test / lint-and-test (pull_request) in forked repo.
Reopen this PR for verifying there's no regression.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9089164) 72.72% compared to head (4145274) 72.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          38       38           
  Lines        3733     3733           
=======================================
  Hits         2715     2715           
  Misses        760      760           
  Partials      258      258           
Flag Coverage Δ
unittests 72.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alva8756
Copy link
Contributor Author

Alva8756 commented Dec 11, 2023

Hi @DoctorVin @joelrebel ,
I am reopening this PR for running PR checks since we haven't enabled it in forked repo.

It looks trivy-container-scan / sec-scan-trivy-1 (pull_request) reports CVE Vulnerability: nkeys:v0.4.4, otelgin:v0.42.0, net:v0.14.0, grpc:v1.57.0.

I am confused that HEAD is already using those versions of each libraries. Why it's reporting errors to this PR.
I have tried re-run failure tests but it keeps failing.

I am wondering if you see such issues before? Thanks for your help!

Update:
I have enabled Linting and Test / lint-and-test (pull_request) in forked repo.
trivy-container-scan remains disabled due to the warning This scheduled workflow is disabled because scheduled workflows are disabled by default in forks.. I am not confident if I can enable it.

@joelrebel
Copy link
Member

joelrebel commented Dec 13, 2023

I have enabled Linting and Test / lint-and-test (pull_request) in forked repo.
trivy-container-scan remains disabled due to the warning This scheduled workflow is disabled because scheduled workflows are disabled by default in forks.. I am not confident if I can enable it.

Lets get these changes merged and, then delete this repo and re-create a new one - so its not a fork?
unless @DoctorVin has other ideas here

@DoctorVin
Copy link
Contributor

I have enabled Linting and Test / lint-and-test (pull_request) in forked repo.
trivy-container-scan remains disabled due to the warning This scheduled workflow is disabled because scheduled workflows are disabled by default in forks.. I am not confident if I can enable it.

Lets get these changes merged and, then delete this repo and re-create a new one - so its not a fork? unless @DoctorVin has other ideas here

Do we even need this PR in this repo? It's more important for FleetDB, IMO, so that we can get past the DDL issue keeping us at v21 of CrDB? I propose we just close this and confine our work going forward to fleetDB.

@joelrebel
Copy link
Member

I have enabled Linting and Test / lint-and-test (pull_request) in forked repo.
trivy-container-scan remains disabled due to the warning This scheduled workflow is disabled because scheduled workflows are disabled by default in forks.. I am not confident if I can enable it.

Lets get these changes merged and, then delete this repo and re-create a new one - so its not a fork? unless @DoctorVin has other ideas here

Do we even need this PR in this repo? It's more important for FleetDB, IMO, so that we can get past the DDL issue keeping us at v21 of CrDB? I propose we just close this and confine our work going forward to fleetDB.

My apologies for the confusion, for some reason I assumed this PR was on the fleetDB repo. Ignore my comment here.

@Alva8756 Alva8756 closed this Dec 18, 2023
@Alva8756
Copy link
Contributor Author

Alva8756 commented Dec 18, 2023

Since the PR in the fleetdb already merged, close this PR.
This PR meant to be testing and clarification not to be merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants