-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Merge all sql files into one #252
Conversation
I realized we don't have |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 38 38
Lines 3733 3733
=======================================
Hits 2715 2715
Misses 760 760
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @DoctorVin @joelrebel , It looks I am confused that I am wondering if you see such issues before? Thanks for your help! Update: |
Lets get these changes merged and, then delete this repo and re-create a new one - so its not a fork? |
Do we even need this PR in this repo? It's more important for FleetDB, IMO, so that we can get past the DDL issue keeping us at v21 of CrDB? I propose we just close this and confine our work going forward to fleetDB. |
My apologies for the confusion, for some reason I assumed this PR was on the fleetDB repo. Ignore my comment here. |
Since the PR in the fleetdb already merged, close this PR. |
This is the copy of metal-toolbox/fleetdb#4 for verifying PR
Linting and Test / lint-and-test (pull_request)