Vc/updates #9
Merged
Vc/updates #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix in place upstream
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 72.72% 72.74% +0.01%
==========================================
Files 38 38
Lines 3733 3735 +2
==========================================
+ Hits 2715 2717 +2
Misses 760 760
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Alva8756
approved these changes
Dec 18, 2023
Comment on lines
+28
to
+30
| // This is a dummy variable to prevent unused regexp import error | ||
| var _ = ®exp.Regexp{} | ||
|
|
There was a problem hiding this comment.
nit: You should actually be able to handle this at the import by doing:
import (
_ "regexp"
)
edit: I see this is a generated file, so not sure if you added this line.
There was a problem hiding this comment.
yep, not me, that's the generator.
coffeefreak101
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here:
v23.1.13crdbdriver. Note: even this doesn't quite give us what we need, so I need to submit a PR against the forked repo.--enable-soft-deletes(which resolved a BUNCH of weird test failures).I tested by doing
make test-database,make unit-test, andmake integration-test. Everything came up clean.