Rename environment prefix, app name and test database name to fleetdb #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alva8756
changed the title
DoctorVin
previously approved these changes
Jan 2, 2024
quickstart.yml
Outdated
| serverservice: | ||
| image: ghcr.io/metal-toolbox/hollow-serverservice:v0.16.0 | ||
| fleetdb: | ||
| image: ghcr.io/metal-toolbox/fleetdb:v0.16.0 |
There was a problem hiding this comment.
Note for later: we'll want to update the version of FleetDB to 1.0 when we bring that live to production.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 72.69% 72.69%
=======================================
Files 38 38
Lines 3736 3736
=======================================
Hits 2716 2716
Misses 762 762
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Since we have almost finished migration, we can start to push new releases. |
DoctorVin
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
FLEETDB_instead ofSERVERSERVICE_environment variable prefix for configuring fleetdb.Hi @DoctorVin and @joelrebel ,
We also need to update corresponding environment variables in https://github.com/equinixmetal/k8s-fleetdb/tree/main
It may be simpler for us to merge this PR and change k8s-fleetdb before launching fleetdb on production?
Keep using
ServerService_is also convenient. We can rename the prefix later after fleetdb has already been launched.I am fine with either. I may need to update the template on the sandbox work depending on the decision.
Do we want to sync up or create a document to discuss the migration plans?