Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-1459]fix get inventory backward compatibility issue #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Alva8756
Copy link
Contributor

This fix will break the existing API tests for getInventory
If you are agree with this solution, I will work on fix the tests.

@Alva8756 Alva8756 requested a review from DoctorVin June 18, 2024 06:08
Copy link
Contributor

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start but doesn't go far enough to ensure that this is actually fixed. I'm mostly concerned that there is data in the attributes table that is not well modeled even as an array of ComponentAttributes.

We should bring this up with the wider group as we plot how to fix this in the long term. Thinking more short-term, we should either make sure that ComponentAttributes contains all the data that is in that table or we could log failures to deserialize the attributes of a component and live with the consequences.

@Alva8756 Alva8756 changed the title [FS-1459]fix Alloy backward compatibility issue [FS-1459]fix get inventory backward compatibility issue Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants