Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix address extraction from anonymous set #23

Merged
merged 2 commits into from
May 30, 2024

Conversation

myromeu
Copy link
Contributor

@myromeu myromeu commented May 19, 2024

Fixes issue #22
Also take account about mixed sets with plain address and subnets like this:

{
  "match": {
    "op": "==",
    "left": {
      "payload": {
        "protocol": "ip",
        "field": "saddr"
      }
    },
    "right": {
      "set": [
        "8.8.8.8",
        "10.96.0.10",
        "21.21.0.242",
        {
          "prefix": {
            "addr": "127.0.0.0",
            "len": 8
          }
        }
      ]
    }
  }
}

@majst01
Copy link
Contributor

majst01 commented May 19, 2024

Thanks for your PR, can you by any chance add some unit-tests to this new functionality ?

@myromeu
Copy link
Contributor Author

myromeu commented May 22, 2024

@majst01 yes, I will do it little bit latter (mb in mid next week)

@myromeu
Copy link
Contributor Author

myromeu commented May 28, 2024

@majst01 hello)

I've finished with tests. Can you check and merge?

@majst01 majst01 merged commit a52b12b into metal-stack:master May 30, 2024
1 check failed
@myromeu myromeu deleted the fix_anon_addr_set branch May 30, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants