Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kind metal-control-plane via containerlab #170

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simcod
Copy link
Collaborator

@simcod simcod commented Jun 20, 2024

No description provided.

@simcod simcod requested a review from a team as a code owner June 20, 2024 09:50
@simcod simcod requested a review from robertvolkmann June 20, 2024 09:51
@majst01
Copy link
Contributor

majst01 commented Jun 20, 2024

It should be still possible to only spin up the control plane without any switches ? Is this the case ? If yes this would be awesome.

@robertvolkmann
Copy link
Contributor

Would be possible with a third topology file.

@robertvolkmann
Copy link
Contributor

@simcod Could you test https://containerlab.dev/cmd/deploy/#node-filter and document the behavior? We could introduce the additional make targets "only-control-plane" and "only-partition".

@@ -22,14 +22,13 @@ The mini-lab is a small, virtual setup to locally run the metal-stack. It deploy
- Linux machine with hardware virtualization support
- kvm as hypervisor for the VMs (you can check through the `kvm-ok` command)
- [docker](https://www.docker.com/) >= 20.10.13 (for using kind and our deployment base image)
- [kind](https://github.com/kubernetes-sigs/kind/releases) == v0.20.0 (for hosting the metal control plane)
- [containerlab](https://containerlab.srlinux.dev/install/) >= v0.47.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the dependency to >= v0.55.0

@@ -22,14 +22,13 @@ The mini-lab is a small, virtual setup to locally run the metal-stack. It deploy
- Linux machine with hardware virtualization support
- kvm as hypervisor for the VMs (you can check through the `kvm-ok` command)
- [docker](https://www.docker.com/) >= 20.10.13 (for using kind and our deployment base image)
- [kind](https://github.com/kubernetes-sigs/kind/releases) == v0.20.0 (for hosting the metal control plane)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind ist still required

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested without local kinD installation. Besides the .kubeconfig file created with root ownership, the setup still works.

@simcod simcod marked this pull request as draft June 24, 2024 13:31
@simcod
Copy link
Collaborator Author

simcod commented Jun 25, 2024

At the moment, the use of kinD via containerlab is not stable enough. Therefore, we should stick with the current configuration.

@Gerrit91
Copy link
Contributor

Gerrit91 commented Jul 2, 2024

Should we close then?

@majst01
Copy link
Contributor

majst01 commented Jul 2, 2024

Should we close then?

We should discuss together, still find this approach reasonable

@Gerrit91
Copy link
Contributor

Gerrit91 commented Jul 2, 2024

At the moment, the use of kinD via containerlab is not stable enough. Therefore, we should stick with the current configuration.

@simcod Why is not stable enough? 😅

@simcod
Copy link
Collaborator Author

simcod commented Jul 4, 2024

At the moment, the use of kinD via containerlab is not stable enough. Therefore, we should stick with the current configuration.

@simcod Why is not stable enough? 😅

It is possible to create the cluster with the --node-selector option. However, it is not possible to destroy it with this option. So the feature has currently some known issues. More information can be fond here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants