Add firewaldistance to InstallerConfig #145
Conversation
| RaidEnabled: raidEnabled, | ||
| RootUUID: rootUUiD, | ||
| FirewallRules: alloc.FirewallRules, | ||
| FirewallDistance: 0, |
There was a problem hiding this comment.
In general I am not sure if this is required in the metal-hammer at all, but if we want to do it here, too, then the distance should be high because only then newly created firewalls do not attract traffic immediately.
There was a problem hiding this comment.
This was the idea behind it and it works pretty good in the code.
metal-stack/metal-networker#98 (comment)
There was a problem hiding this comment.
There was a problem hiding this comment.
A High distance like 10 should be enough?
There was a problem hiding this comment.
Highest value used by the FCM is 8: https://github.com/metal-stack/firewall-controller-manager/blob/91feb1f750de70a2008b81f3bf0dda41aa4be13f/api/v2/types_firewallset.go#L15
There was a problem hiding this comment.
In general I am not sure if this is required in the metal-hammer at all, but if we want to do it here, too, then the distance should be high because only then newly created firewalls do not attract traffic immediately.
It's good to have that already in the metal-hammer. Otherwise if we roll firewalls and the new one starts up it has the smallest distance until the firewall-controller starts. This might disturb outgoing traffic flows.
If firewalls start with a high distance they attract no traffic and the firewall-controller-manager decides to configure a lower distance once the new one is configured and the old firewall is destroyed.
Description
In order for the firewall controller to give the metal-network the distance of its firewall the InstallerConfig which is used by the fc needs to be updated to include the firewallDistance.