Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #31

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Upgrade dependencies #31

merged 3 commits into from
Feb 21, 2024

Conversation

robertvolkmann
Copy link
Contributor

@robertvolkmann robertvolkmann commented Feb 15, 2024

ansible==8.4.0 -> 9.2.0
ansible-core 2.15.4 -> 2.16.3
gcloud 445.0.0 -> 464.0.0
humanfriendly 9.2 -> 10.0
Jinja2 3.1.2 -> 3.1.3
netaddr 0.8.0 -> 1.1.0

ansible==8.4.0 -> 8.7.0
ansible-core 2.15.4 -> 2.15.9
gcloud 445.0.0 -> 464.0.0
humanfriendly 9.2 -> 10.0
Jinja2 3.1.2 -> 3.1.3
netaddr 0.8.0 -> 1.1.0
@Gerrit91
Copy link
Contributor

Would it be possible to go to Ansible 9.2.0 straight?

@Gerrit91 Gerrit91 merged commit 3d60db0 into master Feb 21, 2024
1 check passed
@Gerrit91 Gerrit91 deleted the update-dependencies branch February 21, 2024 12:22
@Gerrit91
Copy link
Contributor

Gerrit91 commented Feb 21, 2024

Unfortunately, still the issue with ansible-galaxy was not resolved for us. Probably we should migrate to Ansible Collections layout where I dropped all the stuff with symlinks (initial try was made here and it worked without problems).

The problem is that in the previous version's of Ansible, ansible-galaxy extracted a role like this:

root@gerrit-XPS-13-9310:/mini-lab# ls -alh /root/.ansible/roles/metal-roles/control-plane/roles/nsq/defaults/main/                                                                                                 
total 12K
drwxr-xr-x 2 root root 4.0K Feb 21 15:03 .
drwxr-xr-x 3 root root 4.0K Feb 21 15:03 ..
lrwxrwxrwx 1 root root   35 Feb 21 15:03 control-plane-defaults -> ../../../../control-plane-defaults/
lrwxrwxrwx 1 root root   23 Feb 21 15:03 global-defaults -> ../../../../../defaults
-rw-r--r-- 1 root root  849 Feb  7 11:16 main.yaml

But now it resolves it like:

root@gerrit-XPS-13-9310:/mini-lab# ls -alh /root/.ansible/roles/metal-roles/control-plane/roles/nsq/defaults/main/       
total 12K
drwxr-xr-x 2 root root 4.0K Feb 21 15:42 .
drwxr-xr-x 3 root root 4.0K Feb 21 15:42 ..
lrwxrwxrwx 1 root root   36 Feb 21 15:42 control-plane-defaults -> control-plane/control-plane-defaults
lrwxrwxrwx 1 root root    8 Feb 21 15:42 global-defaults -> defaults
-rw-r--r-- 1 root root  849 Feb 21 13:19 main.yaml

@robertvolkmann
Copy link
Contributor Author

Other solution would be to use a separate role for the variable defaults, similar to kubespray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants