Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PXE Vlan #99

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Fix for PXE Vlan #99

merged 6 commits into from
Sep 4, 2023

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jul 31, 2023

Now all deployments use the same topology for the PXE/DHCP Vlan setup, we can now use the built-in template, to make the frr template during deployment obsolet.

@majst01 majst01 requested a review from a team as a code owner July 31, 2023 05:20
@robertvolkmann
Copy link
Contributor

Do we really want that the firewalls know the PXE Vlans?

@majst01
Copy link
Contributor Author

majst01 commented Jul 31, 2023

Do we really want that the firewalls know the PXE Vlans?

For sure not, i simply copied over the template which is actually deployed in both environments.

Maybe we should add another review round to the frr template, this will be true for both, sonic and cumulus flavour

@robertvolkmann
Copy link
Contributor

To prevent this, we should use something like:

 address-family ipv4 unicast
  redistribute connected route-map LOOPBACKS
  redistribute connected route-map VLAN4000
  neighbor FIREWALL allowas-in 2
  neighbor FIREWALL route-map LOOPBACKS out
  {{- range $k, $f := .Ports.Firewalls }}
  neighbor {{ $f.Port }} route-map fw-{{ $k }}-in in
  {{- end }}
 exit-address-family
 !
...
route-map LOOPBACKS permit 10
  match interface Loopback0
!
ip prefix-list VLAN4000 seq 10 permit <local PXE Vlan CIDR>
route-map VLAN4000 permit 10
  match ip address prefix-list VLAN4000
!

@Gerrit91 Gerrit91 requested a review from mreiger August 17, 2023 12:15
@mreiger
Copy link
Contributor

mreiger commented Aug 18, 2023

@robertvolkmann Your suggestion looks good to me.

Even simpler maybe:

route-map VLAN4000 permit 10
  match interface Vlan4000

What do you think?

@robertvolkmann
Copy link
Contributor

I tried but it doesn't worked for me. I don't know why.

@Gerrit91 Gerrit91 merged commit 32b105a into master Sep 4, 2023
1 check passed
@Gerrit91 Gerrit91 deleted the pxe-vlan-fix-for-sonix branch September 4, 2023 09:26
@Gerrit91
Copy link
Contributor

Gerrit91 commented Sep 4, 2023

I created a follow-up issue regarding visibility of the VLANs on the firewalls: #101. @robertvolkmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants