Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example in readme #150

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ainghazal
Copy link
Contributor

The current example snippet in the README needed some work to catch up with the latest code changes.
This commit updates the usage shown in the example to create a namespace, and passes the expected context to the goipam.New constructor.

@ainghazal ainghazal requested a review from a team as a code owner June 25, 2024 18:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.71%. Comparing base (6d48337) to head (7cd2781).
Report is 2 commits behind head on master.

Current head 7cd2781 differs from pull request most recent head 95d90cb

Please upload reports for the commit 95d90cb to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #150       +/-   ##
===========================================
- Coverage   63.03%   46.71%   -16.33%     
===========================================
  Files          11       16        +5     
  Lines        1672     3427     +1755     
===========================================
+ Hits         1054     1601      +547     
- Misses        398     1596     +1198     
- Partials      220      230       +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@majst01 majst01 merged commit afa658d into metal-stack:master Jun 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants