Skip to content

Commit

Permalink
Skip bios modifications on newer microclouds (#69)
Browse files Browse the repository at this point in the history
  • Loading branch information
majst01 authored Nov 18, 2024
1 parent 05ce016 commit fd2ba72
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions internal/vendors/supermicro/sum.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ const (
X12DPT_B6
// G1 GPU machine
X13DDW_A
// Newer Microclouds
X13SCD_F
)

var (
Expand All @@ -47,6 +49,8 @@ var (
"X12DPT-B6": X12DPT_B6,
// G1 GPU Machine
"X13DDW-A": X13DDW_A,
// Newer Microclouds
"X13SCD-F": X13SCD_F,
}

// SUM does not complain or fail if more boot options are given than actually available
Expand Down Expand Up @@ -264,7 +268,7 @@ func (s *sum) ConfigureBIOS() (bool, error) {
s.log.Infow("firmware", "is", firmware, "board", s.boardModel, "boardname", s.boardName)

// We must not configure the Bios if UEFI is already activated and the board is one of the following.
if firmware == kernel.EFI && (s.boardModel == X11SDV_8C_TP8F || s.boardModel == X11SDD_8C_F || s.boardModel == X12DPT_B6 || s.boardModel == X13DDW_A) {
if firmware == kernel.EFI && (s.boardModel == X11SDV_8C_TP8F || s.boardModel == X11SDD_8C_F || s.boardModel == X12DPT_B6 || s.boardModel == X13DDW_A || s.boardModel == X13SCD_F) {
return false, nil
}

Expand Down Expand Up @@ -292,7 +296,7 @@ func (s *sum) ConfigureBIOS() (bool, error) {
// EnsureBootOrder ensures BIOS boot order so that boot from the given allocated OS image is attempted before PXE boot.
func (s *sum) EnsureBootOrder(bootloaderID string) error {
s.bootloaderID = bootloaderID
if s.boardModel == X13DDW_A || s.boardModel == X12DPT_B6 {
if s.boardModel == X13DDW_A || s.boardModel == X12DPT_B6 || s.boardModel == X13SCD_F {
s.log.Infow("GPU board detected, skip bios modification", "board", s.boardName)
return nil
}
Expand Down Expand Up @@ -431,7 +435,7 @@ func (s *sum) checkBootOptionAt(index int, bootOption string) bool {
if setting.Name != fmt.Sprintf("UEFI Boot Option #%d", index) {
continue
}
case X13DDW_A, X12DPT_B6:
case X13DDW_A, X12DPT_B6, X13SCD_F:
// FIXME
}

Expand Down

0 comments on commit fd2ba72

Please sign in to comment.