Explicitly reconcile firewall deployment in maintenance time window. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deployment-in-maintenance
|
needs rebase |
majst01
reviewed
May 28, 2024
| if !gardener.EffectiveShootMaintenanceTimeWindow(cluster.Shoot).Contains(time.Now()) { | ||
| // note that this prevents updating the firewall image even when annotating the shoot explicitly with the maintainenance annotation | ||
| // if a user wants to update the firewall immediately he needs to specify the new firewall image in the spec |
There was a problem hiding this comment.
This might not work in all cases, e.g. if the image is already at the latest version. Therefore i propose to skip this check if the reconcile annotation is present. WDYT ?
There was a problem hiding this comment.
Unfortunately the controller never sees a reconcile or maintenance annotation in these resources. If we remove this check it will update the firewall potentially outside the maintenance time window when changing something in the infrastructure config (e.g. when adding an egress rule or something like that).
So if a user wants like to immediately update outside the maintenance time window with a shorthand image, he needs to change to a specific firewall image instead.
majst01
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References metal-stack/firewall-controller-manager#43, metal-stack/firewall-controller-manager#53.