Remove dependency on metal-lib #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not worth the effort because go only pulls the dependencies of the package in the external dependency. As you can see go.sum only removes the metal-lib and no other deps, this is because the pointer package does not have any external deps except stdlib |
|
Using a dependency to replace a one-liner reminds me of the nightmares in the JavaScript world. |
majst01
reviewed
Mar 14, 2024
robertvolkmann
force-pushed
the
remove-metal-lib
branch
from
cb97a3a to
e5b94c8
Compare
robertvolkmann
force-pushed
the
remove-metal-lib
branch
from
e5b94c8 to
bb4e8b8
Compare
|
Impact too small, decided not to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.