Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add streaming to upload/download of backup #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add streaming to upload/download of backup #102

wants to merge 3 commits into from

Conversation

ostempel
Copy link
Collaborator

@ostempel ostempel commented Dec 10, 2024 •
edited by Gerrit91
Loading

Description

changed from file-handling to streaming for download/upload of backup-providers.

References:

This was extracted from #101 in order to reduce amount of changes.

@ostempel ostempel added the enhancement New feature or request label Dec 10, 2024
@ostempel ostempel requested a review from Gerrit91 December 10, 2024 13:31
@ostempel ostempel marked this pull request as ready for review December 10, 2024 13:32
@ostempel ostempel requested a review from a team as a code owner December 10, 2024 13:32
Gerrit91
Gerrit91 reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this. The CI does not pass and I left some initial comments.

cmd/internal/backup/providers/contract.go Outdated Show resolved Hide resolved
cmd/internal/backup/providers/gcp/gcp.go Show resolved Hide resolved
cmd/internal/backup/providers/s3/s3.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostempel @Gerrit91