Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PayablewithBankingEvent.sol #70

Closed
wants to merge 2 commits into from
Closed

Create PayablewithBankingEvent.sol #70

wants to merge 2 commits into from

Conversation

Gokul-Ks
Copy link

@Gokul-Ks Gokul-Ks commented Oct 9, 2022 •
edited
Loading

Description

Created Solidity contract for simple banking processes

Fixes #63

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Thank you for opening your first pull request in our repository, one of our maintainers will get in touch with you soon.

DO NOT FORGET TO ADD METAMASK WALLET ADDRESS IN THE AUTH FORM
We at Metafy have some special rewards and swags for the top contributors in general repos and every contributor in web3 repos
For being eligible for that, please authenticate yourself using this link:
https://hacktoberfest.auth.metafy.social

Rewards : T-shirts & NFT ( for blockchain contributions )

Best of luck on your Contributions
For further queries you can join our discord for support : https://discord.gg/W6PmEjjQsA

@github-actions github-actions bot added PR:Ready-to-Review hacktoberfest-accepted Hacktoberfest Accepted Pull Requests labels Oct 9, 2022
advaita-saha
advaita-saha requested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@advaita-saha advaita-saha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete the mentioned changes

contracts/Misc/PayablewithBankingEvent.sol Outdated Show resolved Hide resolved
Gokul-Ks
Gokul-Ks commented Oct 10, 2022
View reviewed changes
Copy link
Author

@Gokul-Ks Gokul-Ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have completed the requested change @advaita-saha

@advaita-saha
Copy link
Contributor

Your contract is not getting compiled
https://github.com/metafy-social/web3-smart-contracts/actions/runs/3213673901/jobs/5253511613

Please fix these issues

@Gokul-Ks Gokul-Ks closed this by deleting the head repository Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advaita-saha advaita-saha advaita-saha requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest Accepted Pull Requests PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smart Contract for Simple Banking
2 participants
@Gokul-Ks @advaita-saha