Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DutchAuction.sol #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sadityakumar9211
Copy link

Description

Optimised the smart contract using the custom error with revert statements. This significantly reduces the gas cost in smart contract transactions.
Give a summary of the change that you have made

I have modified the smart contract to use custom error with revert statements rather than using require statement with error strings which is significantly expensive compared to the former.

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR

Optimized the smart contract using the custom error with revert statements. This significantly reduces the gas cost in smart contract.
@github-actions
Copy link
Contributor

Thank you for opening your first pull request in our repository, one of our maintainers will get in touch with you soon.

DO NOT FORGET TO ADD METAMASK WALLET ADDRESS IN THE AUTH FORM
We at Metafy have some special rewards and swags for the top contributors in general repos and every contributor in web3 repos
For being eligible for that, please authenticate yourself using this link:
https://metafy.social/signup

Rewards : T-shirts & NFT ( for blockchain contributions )

Best of luck on your Contributions
For further queries you can join our discord for support : https://discord.gg/W6PmEjjQsA

@github-actions
Copy link
Contributor

PR is not linked to any issue, please make the corresponding changes in the body.

fixed breaking changes in the contract
@github-actions
Copy link
Contributor

PR is not linked to any issue, please make the corresponding changes in the body.

@github-actions
Copy link
Contributor

PR is not linked to any issue, please make the corresponding changes in the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant