Upgrade Gradle wrapper to version 8.6

[blackwinter]

Resolves #484. What about secondary objective "Simplify the release process"?

Reviewers: Please verify that all use cases as well as release steps are still working.

Changes:

• install¹ -> publishToMavenLocal, uploadArchives -> publishAllPublicationsToMavenRepository: "The maven plugin has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the maven-publish plugin instead."
• publish -> publishAllPublicationsToGitHubPackagesRepository (in .github/workflows/publish.yml): Action is intended to "Publish package to GitHub Packages", so use specific task.
• editorconfig -> editorconfig-checker: Editorconfig plugin is not compatible with Gradle 8.x ("void org.gradle.workers.WorkerExecutor.submit(java.lang.Class, org.gradle.api.Action)") and upgrading to a compatible version (0.1.0) would raise the minimum Java version requirement to 16 (see also Include editorconfig-checker to complement editorconfig-gradle-plugin. metafacture-fix#179 and Upgrade Gradle wrapper to version 8.x. metafacture-fix#283). Surfaced some whitespace violations which had to be fixed.
• signing.required: No longer dependent on presence of task uploadArchives. Is this needed?
• signing.signPom, signArchives (fix): No longer configured. Is this needed? Is it done by default now?
• testRuntime -> testRuntimeOnly: "The testRuntime configuration has been deprecated for dependency declaration. This will fail with an error in Gradle 7.0. Please use the testRuntimeOnly configuration instead."
• runtime <configuration> -> runtimeClasspath.extendsFrom <configuration>: "Adding a Configuration as a dependency is a confusing behavior which isn't recommended. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. If you're interested in inheriting the dependencies from the Configuration you are adding, you should use Configuration#extendsFrom instead."
• archiveName -> archiveFileName.get(): "The AbstractArchiveTask.archiveName property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the archiveFileName property instead."
• classifier -> archiveClassifier: "Could not set unknown property 'classifier' for task [...] of type [...]."
• main -> mainClass: "The JavaExec.main property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the mainClass property instead."
• outputDir -> classesDirectory: "The SourceDirectorySet.outputDir property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the classesDirectory property instead."

(See also metafacture/metafacture-fix#57 and metafacture/metafacture-fix#341 as well as Upgrading Gradle 6 to 7 and Upgrading Gradle 7 to 8.)

Wiki changes (after pull request has been merged):

• Code Quality and Style: Build Environment:

  -$ ./gradlew.sh install
  +$ ./gradlew.sh publishToMavenLocal

• Maintainer Guidelines: Upload to Sonatype:

  -1. Now you can build and upload the release candidate to sonatype (note that `./gradlew` should inform you to make a "snapshot build". If the version doesn't end with `-SNAPSHOT` the artifacts will not be uploaded to sonatypes snapshot repository!). Also, comment out `releaseRepositoryUrl...` in your `gradle.properties` so that the `snapshotRepository` will be used. Then:
  +1. Now you can build and upload the release candidate to sonatype (note that `./gradlew` should inform you to make a "snapshot build". If the version doesn't end with `-SNAPSHOT` the artifacts will not be uploaded to sonatypes snapshot repository!):

  -./gradlew clean; ./gradlew install; ./gradlew uploadArchives
  +./gradlew clean; ./gradlew publishToMavenLocal; ./gradlew publishAllPublicationsToMavenRepository

• Maintainer Guidelines: Publish to GithubPackages:
  Possibly replace gradlew publish with ./gradlew publishAllPublicationsToGitHubPackagesRepository?
• Maintainer Guidelines: Making a release:

  -./gradlew clean; ./gradlew install; ./gradlew uploadArchives
  +./gradlew clean; ./gradlew publishToMavenLocal; ./gradlew publishAllPublicationsToMavenRepository

---

¹ Kept for compatibility purposes, but deprecated.

[blackwinter]

Possible next step: Address Gradle 9 deprecations.

• build.gradle, line 85:

  The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#java_convention_deprecation
  The org.gradle.api.plugins.Convention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#deprecated_access_to_conventions
  

• build.gradle, line 86:

  The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#java_convention_deprecation
  The org.gradle.api.plugins.Convention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.6/userguide/upgrading_version_8.html#deprecated_access_to_conventions
  

Resolved with afbb5c8.

[fsteeg]

What I use (install / publishToMavenLocal and check) seems to work fine.

(Both on Java 8 and 11.)

I did notice this log output, but I'm also getting that on master (even twice there):

Task :metafacture-biblio:compileTestJava
[Fatal Error] byte-buddy-parent-1.9.10.pom:789:1: Content is not allowed in trailing section.

[blackwinter]

Thanks for testing!

I did notice this log output, but I'm also getting that on master (even twice there):

Hm, I've never seen this message. Still don't.

Did you run on a clean build? Does --refresh-dependencies have any effect?

[fsteeg]

Did you run on a clean build? Does --refresh-dependencies have any effect?

No change with clean and --refresh-dependencies (both on Java 8 and 11).

[dr0i]

Just tested the publishing to oss.sonatype.org to publish it to maven central. However, the publishAllPublicationsToMavenRepository just uploads files ending with .module (and the pom) to oss.sonatype.org, while we need .jar .javadoc and sources.jar (which all correctly appear in the local repo (~/.m2/...). I don't had time to further investigate - you haven't already an idea about why this is so?

Re "signing": yes I would say we should provide that. And the .asc are still generated - look at the the local maven repo 👍 .

[blackwinter]

I don't had time to further investigate - you haven't already an idea about why this is so?

No, I don't have any idea either. It seems to be published correctly to localEmbedded (which may have been the reason for this repository in the first place, to be able to inspect the publication artifacts?):

     29 jar
     29 jar.md5
     29 jar.sha1
     29 jar.sha256
     29 jar.sha512
     29 module
     29 module.md5
     29 module.sha1
     29 module.sha256
     29 module.sha512
     29 pom
     29 pom.md5
     29 pom.sha1
     29 pom.sha256
     29 pom.sha512
     58 xml
     58 xml.md5
     58 xml.sha1
     58 xml.sha256
     58 xml.sha512

[dr0i]

localEmbedded is good to be removed 👍
Switched to the newer gradle-nexus publish-plugin and added signing to distributions.
Wiki pages have to be updated accordingly if merged.

[blackwinter]

Wiki pages have to be updated accordingly if merged.

I'm unclear as to what your removal of snapshotRepositoryUrl entails (see b7d0409). Will you update the Maintainer Guidelines? Or can you give me instructions on what to change specifically?

[dr0i]

Re snapshotRepositoryUrl : see https://github.com/gradle-nexus/publish-plugin?tab=readme-ov-file#publishing-to-maven-central-via-sonatype-ossrh . I will update Maintainer Guidelines.

[dr0i]

Updated Maintainer Guidelines.