Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Java 11 forward compatibility. #519

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

blackwinter
Copy link
Member

@blackwinter blackwinter commented Feb 5, 2024

Prerequisite for #518.

@blackwinter
Copy link
Member Author

Clarification: This pull request only allows the project to be built with Java 11, it doesn't require it. So it's a necessary prerequisite for #518, but it's not sufficient to "resolve" it.

This would be different for metafacture-fix where the upgrade of the Xtext Builder plugin (see metafacture/metafacture-fix#283) would make Java 11 a requirement to build the project.

(Also, it might be helpful to differentiate between build time and run time when talking about these requirements.)

@dr0i
Copy link
Member

dr0i commented Feb 6, 2024

Don't we want to bump java version to 11? It seems easy - in build.gradle:

sourceCompatibility = 11
targetCompatibility = 11

Then change the path of java in your execution environment to java 11. Also set the environment variable JAVA_HOME to java 11.

Seems to work just out-of-the-box. Same with metafacture-fix, consuming the MF-core java 11 build.
What I've trouble with atm is to make it work with our play apps.

@blackwinter
Copy link
Member Author

Sure, I'm all for it. That's just not what this pull request is doing.

@dr0i dr0i assigned blackwinter and unassigned dr0i Feb 6, 2024
@blackwinter blackwinter merged commit 0b85363 into master Feb 6, 2024
1 check passed
@blackwinter blackwinter deleted the 518-java11compat branch February 6, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants