Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http/https inconsistencies with GC_Open_Licenses #409

Conversation

tylerjmchugh
Copy link
Contributor

@tylerjmchugh tylerjmchugh commented Oct 30, 2024

Samples and templates were not updated to use https for Open Government Licence - Canada causing them to be invalid with the pre-populated values.

This PR aims to fix this issue by updating the licenses in samples and templates to use https.

Edit: Split some of the changes into #418

@ianwallen ianwallen requested a review from josegar74 October 31, 2024 18:34
@ianwallen ianwallen added this to the 4.2.12 milestone Oct 31, 2024
@ianwallen
Copy link
Contributor

Changes look good however it may affect the validation on FGP

@bo-lu, @josegar74 should we be requesting for this to be back ported to 3.6?

@bo-lu
Copy link
Member

bo-lu commented Oct 31, 2024

@ianwallen @anthonyfok

Hi Ian, I am in support of backporting to 3.6.x, but I will have to check with another team to see if there are any dependencies that can cause breaking changes. I seem to recall that the '-' and '−' was an unfortunately error that wasn't caught until another system became dependent on it (via our CSW).

Regarding HTTP to HTTPS, we will investigate if we can perform a find and replace on the database to upgrade the license to HTTPS and have it default to HTTPS in the future.

Anthony and I are currently prioritizing an OS upgrade on our servers so we will put this in our backlog. It is also due time for us to update the LAC Core Subject Thesaurus.

Btw, our source is now on gccode if you'd like to have a look!

@ianwallen
Copy link
Contributor

For this PR - not the backports. Can you split the PR into 2 parts. One for the https which we can approve quickly.
The one with the hyphen may take longer to get approval it needs more coordination with FGP

@tylerjmchugh
Copy link
Contributor Author

Split the changes unrelated to https into a new PR: #418

@tylerjmchugh tylerjmchugh changed the title Fix inconsistencies with GC_Open_Licenses Fix http/https inconsistencies with GC_Open_Licenses Dec 11, 2024
@josegar74 josegar74 merged commit 7baa470 into metadata101:4.2.x Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants