Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement circuit asserting that points aren't at infinity and public key isn't the neg generator point #339

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Implement circuit asserting that points aren't at infinity and public key isn't the neg generator point #339

wants to merge 40 commits into from

Conversation

NikolayKostadinov21
Copy link
Contributor

Implement circuit asserting that points aren't at infinity and public key isn't the neg generator point.
Improve integration of starky bls

@NikolayKostadinov21
Implement tests cases for bls12_381_components_proofs against ethereu…
211d09e 
…m verify test cases
@NikolayKostadinov21
Update bls_components and shell to run the tests in it - still wip, i…
88614e5 
…t's not building
@NikolayKostadinov21
build(bls_components) Made little changes needed for bls_components t…
6ccdfd1 
…o execute its tests
@NikolayKostadinov21
fix(run_bls12_381_component_proofs.sh) Fix the navigation in the root…
0f2ed35 
… directory
@NikolayKostadinov21
fix: Use unchecked deserialization for G1 & G2
bb7959a
@NikolayKostadinov21
fix: Use unchecked deserialization for G1 & G2 in bls_components.rs
f92897e
@NikolayKostadinov21
miller loop putted outside main bls12381 component proof function
6170454
@NikolayKostadinov21
Add helper comments for verify_bls_at_infinity circuit
53c140a
@NikolayKostadinov21
Implement tests cases for bls12_381_components_proofs against ethereu…
d315a09 
…m verify test cases
@NikolayKostadinov21
Update bls_components and shell to run the tests in it - still wip, i…
414d68a 
…t's not building
@NikolayKostadinov21
build(bls_components) Made little changes needed for bls_components t…
16bd669 
…o execute its tests
@NikolayKostadinov21
fix(run_bls12_381_component_proofs.sh) Fix the navigation in the root…
a6818ee 
… directory
@NikolayKostadinov21
fix: Use unchecked deserialization for G1 & G2
7e3adc4
@NikolayKostadinov21
fix: Use unchecked deserialization for G1 & G2 in bls_components.rs
de89491
@NikolayKostadinov21
miller loop putted outside main bls12381 component proof function
e4bef3c
@NikolayKostadinov21
Add helper comments for verify_bls_at_infinity circuit
a43c151
@NikolayKostadinov21
Rebase main over improve_integration_of_starky_safe
8570b01
@NikolayKostadinov21
Implement point at infinity assert after g1 and g2 points are checked
899ef7a
@NikolayKostadinov21
Remove redundant file from lib.rs
5fa50ea
@NikolayKostadinov21
Start test implementation against points at infinity
9258786
@NikolayKostadinov21
Add test for bls12_381 circuit
ee22588
@NikolayKostadinov21
Implement assert if g1 OR g2 point is at infinity
c3cee46
@NikolayKostadinov21
Implement circuit asserting g1 and g2 point aren't at infinity and pk…
006fa57 
… isn't the neg generator
@NikolayKostadinov21
Rebase over main
0ade2ab
@NikolayKostadinov21
Refactor bls12_381 and bls12_381_components_proofs based on changes p…
f21c2dd 
…erformed on bls_components
@NikolayKostadinov21
Refactor test_bls12_381_circuit in VerifyIsNotAtInfinityCircuit
1c9f33b
@NikolayKostadinov21
Improve test_bls12_381_circuit
467d8f4
@NikolayKostadinov21
Remove verification of proofs in VerifyIsNotAtInfinityCircuit since…
7dde05c 
… we will only use the public inputs of second miller loop and first pariing precompile
@NikolayKostadinov21
Fix error in test_bls12_381_circuit
7fceb12
@NikolayKostadinov21
Refactor VerifyIsNotAtInfinityCircuit but tests are not failling as e…
a31af64 
…xpected
@NikolayKostadinov21 NikolayKostadinov21 self-assigned this Jun 12, 2024
@NikolayKostadinov21 NikolayKostadinov21 removed the request for review from Xearty June 12, 2024 09:32
Dimo99
Dimo99 reviewed Jun 13, 2024
View reviewed changes
beacon-light-client/plonky2/crates/circuit_executables/scripts/bls12-381-tests Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the convention to put submodules in the vendor folder

Dimo99
Dimo99 reviewed Jun 13, 2024
View reviewed changes
vendor/circom-pairing Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional

Dimo99
Dimo99 reviewed Jun 13, 2024
View reviewed changes
beacon-light-client/plonky2/.gitignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Dimo99
Dimo99 reviewed Jun 13, 2024
View reviewed changes
...on-light-client/plonky2/crates/circuit_executables/scripts/run_bls12_381_component_proofs.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the script work from any folder using GIT_ROOT env variable

@NikolayKostadinov21 NikolayKostadinov21 force-pushed the improve_integration_of_starky_safe branch from 7ec9048 to ec0c87c Compare June 17, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimo99 Dimo99 Dimo99 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@NikolayKostadinov21 NikolayKostadinov21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolayKostadinov21 @Dimo99