Implement BLS verification #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de `curve25519-dalek`
smanilov
reviewed
May 16, 2024
Comment on lines
+30
to
+32
| if value >= 1 << (8 * LENGHT) { | ||
| assert!(false); | ||
| } |
There was a problem hiding this comment.
Line 30 causes two of the tests added by this PR to fail when invoked in debug mode (cargo test <test_name> without --release). This is because the Rust compiler generates a hidden assert for 1 << (8 * LENGHT) in case the shift value would cause an overflow and that assert fails, if LENGTH is larger than 4 (numeric literals are of type i32 by default). The test passes in release mode, because the asserts are disabled. Note that it is NOT the case that the assert on line 31 fails the tests; it is the hidden/implicit assert mentioned earlier.
To fix, please, replace with:
if LENGHT < std::mem::size_of::<usize>() && value >= 1usize << (8 * LENGHT) {
assert!(false, "value ({value}) does not fit in {LENGHT} bytes");
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.