work around syntaxhighlighter bug causing empty blocks on perlsecret #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlsecret.pod has some code blocks that are very short. The syntax highlighter has a bug when it attempts to strip <![CDATA[ ]]> blocks, which ends up entirely erasing short code block content. The CDATA stripping is only enabled when the useScriptTags option is enabled, which we don't need or want. Work around the bug by disabling useScriptTags. This bug had previously been fixed by patching the vendor library to fix the CDATA stripping. That change was lost in the conversion to node_modules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3228 +/- ##
==========================================
+ Coverage 73.10% 73.14% +0.04%
==========================================
Files 69 69
Lines 2398 2398
Branches 338 338
==========================================
+ Hits 1753 1754 +1
Misses 517 517
+ Partials 128 127 -1 |
|
You rock @haarg ! Thank you very much! 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perlsecret.pod has some code blocks that are very short. The syntax highlighter has a bug when it attempts to strip blocks, which ends up entirely erasing short code block content. The CDATA stripping is only enabled when the useScriptTags option is enabled, which we don't need or want. Work around the bug by disabling useScriptTags.
This bug had previously been fixed by patching the vendor library to fix the CDATA stripping. That change was lost in the conversion to node_modules.
Previously reported as #1228 and fixed by #2292.