use accepts header, not ancient browser detection #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
previously approved these changes
Feb 25, 2024
The proper way to check if a request should return JSON is using the Accepts header. And since we're making these requests in JS, we can control that. The browser detection in the ForBrowsers plugin is based on a IE7 world.
haarg
force-pushed
the
haarg/accepts-not-detect
branch
from
37813f3 to
6e11118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper way to check if a request should return JSON is using the Accepts header. And since we're making these requests in JS, we can control that.
The browser detection in the ForBrowsers plugin is based on a IE7 world.