PICARD-2740: Improve logging of SSL errors

[zas]

Summary

• This is a…
  • Bug fix
  • Feature addition
  • Refactoring
  • Minor / simple change (like a typo)
  • Other
• Describe this change in 1-2 sentences:

Problem

• JIRA ticket (optional): PICARD-2740

Solution

Action

[phw]

That's a bit difficult to test in real. But wouldn't this lead to double logging, as we already log all errors in https://github.com/metabrainz/picard/blob/master/picard/webservice/__init__.py#L511 as well?

[zas]

That's a bit difficult to test in real. But wouldn't this lead to double logging, as we already log all errors in https://github.com/metabrainz/picard/blob/master/picard/webservice/__init__.py#L511 as well?

You can use the commented out code to trigger an error, but basically it provides more details than the existing message;

E: 12:25:28,378 webservice.ssl_errors:363: SSL error: The issuer certificate of a locally looked up certificate could not be found
E: 12:25:28,378 webservice._handle_reply:534: Network request error for https://picard.musicbrainz.org/api/v2/plugins/ -> SSL handshake failed (QT code 6, HTTP code 0)
E: 12:25:28,379 ui/mainwindow.set_statusbar_message:469: Error loading plugins list: SSL handshake failed

The existing message only says the SSL handshake failed, but the new message actually says why.