Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2731: Update for managing translations on Weblate #2288

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

phw
Copy link
Member

@phw phw commented Aug 22, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Translations moved from Transifex to Weblate.

Solution

  • Update the update_constants task to fetch from weblate (PICARD-2652)
  • Remove any usage of weblate, including the now obsolete "pull_translations" task
  • Update the documentation that is part of the repository to reflect any changes

- update_constants pulls from Weblate
- pull_translations got removed (no longer needed)
- Transifex configutation removed
@phw phw requested review from zas and rdswift August 22, 2023 11:08
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Thanks.

Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 78debcc into metabrainz:master Aug 22, 2023
63 checks passed
@phw phw deleted the PICARD-2731-weblate-changes branch August 22, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants