Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The test_pipe_protocol is extremely slow. Without it the full test suite runs on my system with pytest in ~8 seconds. With test_pipe_protocol enabled in runs 71 seconds.
Solution
if message
inpipe_listener
might help with macOS tests. On macOS sometimes the read seems to return an empty string. In normal use in Picard that is ok. The empty string is not a processed message and the loop will just read the next one. Do the same in tests