Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Dropdown songs card for AlbumsOverViewScreen & ArtistsOverviewScreen #523

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Shreyassp002
Copy link
Contributor

This PR introduces a dropdown feature in the ArtistsOverviewScreen and AlbumsOverViewScreen to enhance the user experience by allowing users to view songs in each artist and album.

Changes:

  • Added a dropdown to display the list of songs for each artist and album.
  • Utilized AnimatedVisibility to animate the dropdown with fade-in and fade-out effects, as well as vertical expansion and shrinkage.
  • Used ListenCardSmall to display the corresponding songs within the dropdown.

Result:

video_2025-01-09_23-29-46.mp4

@07jasjeet
Copy link
Collaborator

Hi @Shreyassp002, as much as like this, unfortunately we should navigate the user to artist screen where they can view all the songs. In BP, we do not have a BP artist screen as of now, so I'm not sure how we should go about this. As far as clicking goes, we would want clicking to be reserved for playing the song only and not some other action :)

@Shreyassp002
Copy link
Contributor Author

Hey @07jasjeet ,
Thanks for the clarification! Since BP doesn’t currently have an artist screen, I wanted to ask:

Instead of the play button icon, should I add a dropdown icon that will display the songs of that artist or album? Or should we wait for the implementation of the dedicated BP artist screen before adding such functionality?

Also, clicking to play the song on the BrainzPlayerListenCard will be handled in PR #518.

@07jasjeet
Copy link
Collaborator

Let me see if we can reuse the current artist screen. Until then, we can mark this PR as a draft.

@Shreyassp002 Shreyassp002 marked this pull request as draft January 12, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants