fix inspector rotation use XYZ rotate #482
Conversation
| @@ -51,6 +53,7 @@ class TransformComponent final | |||
|
|
|||
| #ifdef EDITOR_MODE | |||
| static bool m_doUseUniformScale; | |||
| cd::Vec3f m_inspectorEular = cd::Vec3f::Zero(); | |||
There was a problem hiding this comment.
| cd::Vec3f m_inspectorEular = cd::Vec3f::Zero(); | |
| cd::Vec3f m_rotateEular = cd::Vec3f::Zero(); |
As a transform component, it is better not to know what is Inspector because it is an editor concept.
What you need to know about transform component is that we need a temporary eular data storage.
| cd::Vec3f& GetInspectorEular() { return m_inspectorEular; } | ||
| void SetInspectorRotation(const cd::Vec3f& eular) { m_inspectorEular = eular; } |
There was a problem hiding this comment.
| cd::Vec3f& GetInspectorEular() { return m_inspectorEular; } | |
| void SetInspectorRotation(const cd::Vec3f& eular) { m_inspectorEular = eular; } | |
| cd::Vec3f& GetInspectorEular() { return m_inspectorEular; } | |
| const cd::Vec3f& GetInspectorEular() const { return m_inspectorEular; } | |
| void SetInspectorRotation(cd::Vec3f eular) { m_inspectorEular = cd::MoveTemp(eular); } |
For data size larger than 8 bytes, it recommends to use move.
| @@ -11,6 +11,36 @@ | |||
| namespace ImGuiUtils | |||
| { | |||
|
|
|||
| static cd::Matrix3x3 RotateX(float rad) | |||
There was a problem hiding this comment.
You can leverage template + if constexpr to write one function to implement same feature.
| @@ -185,7 +215,7 @@ static bool ImGuiVectorProperty(const char* pName, T& value, cd::Unit unit = cd: | |||
| return dirty; | |||
| } | |||
|
|
|||
| static bool ImGuiTransformProperty(const char* pName, cd::Transform& value) | |||
| static bool ImGuiTransformProperty(const char* pName, cd::Transform& value, cd::Vec3f& inspectorEular) | |||
There was a problem hiding this comment.
It is just OK but doesn't look good in the call side. As a api user, it is strange to apply extra vec3f.
| pitch = std::max(pitch, -89.9f); | ||
|
|
||
| value.SetRotation(cd::Quaternion::FromPitchYawRoll(pitch, eularAngles.y(), eularAngles.z())); | ||
| // XYZ Rotate |
There was a problem hiding this comment.
| // XYZ Rotate |
The comment is useless as you can get XYZ rotate information from codes in next line.
|
What you need to improve is to learn to stand in different positions to review your codes so that you can make your codes more generic.
|
No description provided.