Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change albedo to pink when shader compile failed #445

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Change albedo to pink when shader compile failed #445

merged 1 commit into from
Jan 2, 2024

Conversation

roeas
Copy link
Contributor

@roeas roeas commented Dec 29, 2023

No description provided.

T-rvw
T-rvw approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@T-rvw T-rvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation works in current framework. But actually, it is possible that a material instance already failed to compile. Then a mesh entity selects this material to use.

@roeas roeas merged commit 3a58587 into main Jan 2, 2024
1 of 3 checks passed
@roeas roeas deleted the pink branch January 2, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-rvw T-rvw T-rvw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeas @T-rvw