PBR Review

[roeas]

No description provided.

[T-rvw]

Maybe we can consider to support different kinds of GGX.

[T-rvw]

Try to compare dds to see the difference? Or keep a source image file for debug purpose (for example, .tga).

[roeas]

Old:

New:

According to a this doc Physically Based Rendering in Filament
, the first image seems to be an approximation. Which one should I keep?

[T-rvw]

Old: New: According to a this doc Physically Based Rendering in Filament , the first image seems to be an approximation. Which one should I keep?

🤔Interesting findings. Why an approximation is the good one? I will have a look at it.

[T-rvw]

Here is a LUT_GGX from khronos group's gltf viewer project. Need to flip y due to axis system difference.

More similar to new.png by using compare tool:

But seems more accurate than new.png if you take a look at the left-bottom green part.

So maybe we should copy the lut texture from gltf viewer? To understand these three luts' difference, should write a generate tool by ourselves.
An approximation generator based on UE4 implementation is here : https://github.com/HectorMF/BRDFGenerator?tab=readme-ov-file .