Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParticleSystem #415
ParticleSystem #415
Changes from 85 commits
613b047
08da43d
d710339
640c22a
f228d98
3c4d799
7dfbd94
c7c0244
6cbb342
3ab4b93
8517b7a
05d8e99
78eff11
6158453
96b5fd4
a5ecd92
0f9cd99
a280fef
c64a299
edf2fef
8a00b0c
fce058e
72a4c84
2677d33
43de71b
b8854c4
f7cac2d
a08d819
c8e5d6a
5df948c
bce5782
b0cfccf
6f2b2a8
682f53c
00498f1
c09a157
c9c74a7
f21e667
869730b
e7696f6
3f35fa8
912e264
5683dc0
4b765da
4fbcc30
671db31
c7867f5
a84d286
2390e16
575279e
015962a
38b9989
1aa7063
81b0277
f57041e
6892173
be3e8a5
c5e8226
bc2ee8f
88046c5
4909296
49f2825
1209206
3805e61
bcfdb25
a202866
c36e9e1
f4e46f4
5d7cc9a
728a4b8
86e75e4
d9e790f
22005b8
ca005ee
b130697
0c6c90e
d02d4a4
c953111
6399646
6696528
65e43e4
9cf0121
5b501e6
2f1fc90
8651b1d
88e3e9c
bf8fffa
0c79af7
77a546c
8d88402
ef9e901
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use cd::ParticleType is better because they are all same:
particleEmitterComponent.SetEmitterParticleType(emitter.GetType());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's not.
cd::ParticleEmitterTypeTraits::Type not suit engine::particleType