Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce API wrappers for member variables #266

Merged
merged 3 commits into from
Dec 15, 2023
Merged

reduce API wrappers for member variables #266

merged 3 commits into from
Dec 15, 2023

Conversation

T-rvw
Copy link
Contributor

@T-rvw T-rvw commented Dec 15, 2023

API doesn't need to write get/set property codes now.

  1. Defined type name and its actual type in public/Scene/APITypeTraits.inl. Decide its type : Simple/Complex/Vector/String.
  2. Use EXPORT_XXX_TYPE_APIS in XXX.h
  3. Use PIMPL_XXX_TYPE_APIS in XXX.cpp
  4. Use IMPLEMENT_XXX_TYPE_APIS in XXXImpl.h

@T-rvw T-rvw requested a review from roeas December 15, 2023 04:24
@T-rvw T-rvw requested a review from OVOAOVO December 15, 2023 04:32
@T-rvw T-rvw merged commit beaa2ad into main Dec 15, 2023
4 checks passed
@T-rvw T-rvw deleted the improve_scene_apis branch December 15, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant