Fix move temp const check (#261)

meta4d-me · Dec 11, 2023 · e7f2343 · e7f2343
1 parent 6e4b350
commit e7f2343
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/private/Scene/Light.cpp b/private/Scene/Light.cpp
@@ -177,7 +177,7 @@ const cd::Point& Light::GetPosition() const
 	return m_pLightImpl->GetPosition();
 }
 
-void Light::SetColor(const cd::Vec3f color)
+void Light::SetColor(cd::Vec3f color)
 {
 	m_pLightImpl->SetColor(cd::MoveTemp(color));
 }
@@ -207,7 +207,7 @@ const cd::Direction& Light::GetDirection() const
 	return m_pLightImpl->GetDirection();
 }
 
-void Light::SetUp(const cd::Direction up)
+void Light::SetUp(cd::Direction up)
 {
 	m_pLightImpl->SetUp(cd::MoveTemp(up));
 }

diff --git a/public/Base/Template.h b/public/Base/Template.h
@@ -12,9 +12,10 @@ namespace cd
 template<typename T>
 [[nodiscard]] constexpr std::remove_reference_t<T>&& MoveTemp(T&& value) noexcept
 {
+	using CastType = std::remove_reference_t<T>;
 	static_assert(std::is_lvalue_reference_v<T>, "T is lvalue reference object.");
-	static_assert(!std::is_const_v<T>, "For a const object, MoveTemp doesn't take effect.");
-	return static_cast<std::remove_reference_t<T>&&>(value);
+	static_assert(!std::is_same_v<CastType&, const CastType&>, "For a const object, MoveTemp doesn't take effect.");
+	return static_cast<CastType&&>(value);
 }
 
 }