Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jieba-macros for HMM data generation and remove build.rs file #117

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

sepcnt
Copy link
Contributor

@sepcnt sepcnt commented Dec 25, 2024

Introduce a new jieba-macros package to handle HMM data generation, eliminating the need for file operations in build.rs.

(This would work better with some downstream crates: surrealdb/surrealdb#4556 (comment))

Update dependencies and integrate the macro into the existing codebase.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (7f3b273) to head (9274651).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   84.62%   84.79%   +0.16%     
==========================================
  Files           8        9       +1     
  Lines        2036     2045       +9     
==========================================
+ Hits         1723     1734      +11     
+ Misses        313      311       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #117 will not alter performance

Comparing sepcnt:main (9274651) with main (7f3b273)

Summary

✅ 10 untouched benchmarks

Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 7216263 into messense:main Dec 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants