Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctest support into coverage #105

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

awong-dev
Copy link
Collaborator

@awong-dev awong-dev commented Apr 13, 2024

Moving tests to doctests caused the previous llvm-cov command to stop running them. Adding the --doctest flag puts them back in but requires the nightly toolchain.

Copy link

codspeed-hq bot commented Apr 13, 2024

CodSpeed Performance Report

Merging #105 will not alter performance

Comparing awong-dev:coverage (ab1eab3) with main (e5129f0)

Summary

✅ 10 untouched benchmarks

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (e5129f0) to head (ab1eab3).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #105       +/-   ##
===========================================
+ Coverage   70.44%   82.95%   +12.51%     
===========================================
  Files           8        8               
  Lines        1800     1960      +160     
===========================================
+ Hits         1268     1626      +358     
+ Misses        532      334      -198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awong-dev awong-dev requested a review from messense April 13, 2024 03:53
@awong-dev
Copy link
Collaborator Author

@messense: This one should be pretty straightforward. It fixes the coverage regression I introduced accidentally in #100.

@messense messense merged commit 18dfe4e into messense:main Apr 13, 2024
10 checks passed
@awong-dev awong-dev deleted the coverage branch April 13, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants