Add KeywordExtractConfigBuilder #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
===========================================
+ Coverage 70.44% 84.01% +13.56%
===========================================
Files 8 8
Lines 1800 1989 +189
===========================================
+ Hits 1268 1671 +403
+ Misses 532 318 -214 ☔ View full report in Codecov by Sentry. |
|
Erp...I broke something in the benchmark. But regardless, does this seem like the right direction? will fix that later today. |
CodSpeed Performance ReportMerging #104 will not alter performanceComparing Summary
|
Use builder pattern to construct the KeywordExtractConfig. Expose the KeywordExtractConfig internal state as more rust-standard getters that are just a function with the same identifier as the field name. This code uses the derive_builder module. fixes messense#101
messense
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use builder pattern to construct the KeywordExtractConfig. Expose the KeywordExtractConfig internal state as more rust-standard getters that are just a function with the same identifier as the field name.
This code uses the derive_builder module.
fixes #101