feat(#major); curve; handle TricryptoPoolDeployed event #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pool is tricrypto-pool, sometimes not exist Transfer event that from_address = pool_address and to_address = provider, when RemoveLiquidityOneWithPriceScale event occured. Such as pool='0x7F86Bf177Dd4F3494b841a37e810A34dD56c829B', transaction_hash='0x1804be3e0c5ffa486baefd537b9e393e7d2b53f1abf829e98d10bfa8f12b1d6a'. But the event provide 2 args: coin_amount, coin_idx. When handle RemoveLiquidityOneWithPriceScale, there is no need to use transfer event to get the withdraw tokens and amounts.
harsh9200
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Hi @fishTsai20, I've reviewed your PR, and overall, the changes look really good! Thanks for your work on this.
Just one thing: could you please take a look at and fix the linting issues in the CI/CD? It would ensure everything aligns perfectly with our coding standards. Also, can you send the deployment id of the subgraph?
When pool is tricrypto-pool, sometimes not exist Transfer event that from_address = pool_address and to_address = provider, when RemoveLiquidityOneWithPriceScale event occured. Such as pool='0x7F86Bf177Dd4F3494b841a37e810A34dD56c829B', transaction_hash='0x1804be3e0c5ffa486baefd537b9e393e7d2b53f1abf829e98d10bfa8f12b1d6a'. But the event provide 2 args: coin_amount, coin_idx. When handle RemoveLiquidityOneWithPriceScale, there is no need to use transfer event to get the withdraw tokens and amounts.
subgraph ID : AxY4fTdsWG3Y48apG8T6WwKEwRKGrsr4WFBZWJp5HzYC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Feature request
about: Support Curve new protocol
title: "#feature; curve; handle TricryptoPoolDeployed event"
labels: enhancement
assignees: ishraq8
What do you think is missing?
The Curve configuration was outdated and missing the factory address for the tricrypto pools as well as the function to handle the creation of pool contracts.
Describe the solution you'd like
add CurveTricryptoFactory address
add handle TricryptoPoolDeployed function
support new protocol
Description
The Curve configuration was outdated and missing the factory address for the tricrypto pools as well as the function to handle the creation of pool contracts.
Additional context
https://thegraph.com/explorer/subgraphs/AxY4fTdsWG3Y48apG8T6WwKEwRKGrsr4WFBZWJp5HzYC?view=Query&chain=arbitrum-one