Skip to content

Commit

Permalink
Fix #262 🦦
Browse files Browse the repository at this point in the history
  • Loading branch information
mesqueeb committed Nov 16, 2019
1 parent 22bf1a3 commit 30f4c87
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 5 deletions.
6 changes: 5 additions & 1 deletion dist/index.cjs.js
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,11 @@ function pluginActions (Firebase) {
}
if (!getters.signedIn)
return resolve();
var identifier = createFetchIdentifier({ where: where, orderBy: orderBy });
var identifier = createFetchIdentifier({
where: where,
orderBy: orderBy,
pathVariables: state._sync.pathVariables
});
var fetched = state._sync.fetched[identifier];
// We've never fetched this before:
if (!fetched) {
Expand Down
6 changes: 5 additions & 1 deletion dist/index.esm.js
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,11 @@ function pluginActions (Firebase) {
}
if (!getters.signedIn)
return resolve();
var identifier = createFetchIdentifier({ where: where, orderBy: orderBy });
var identifier = createFetchIdentifier({
where: where,
orderBy: orderBy,
pathVariables: state._sync.pathVariables
});
var fetched = state._sync.fetched[identifier];
// We've never fetched this before:
if (!fetched) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vuex-easy-firestore",
"version": "1.34.4",
"version": "1.34.5",
"description": "Easy coupling of firestore and a vuex module. 2-way sync with 0 boilerplate!",
"main": "dist/index.cjs.js",
"module": "dist/index.esm.js",
Expand Down
6 changes: 5 additions & 1 deletion src/module/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,11 @@ export default function (Firebase: any): AnyObject {
console.log(`%c fetch for Firestore PATH: ${getters.firestorePathComplete} [${state._conf.firestorePath}]`, 'color: goldenrod')
}
if (!getters.signedIn) return resolve()
const identifier = createFetchIdentifier({where, orderBy})
const identifier = createFetchIdentifier({
where,
orderBy,
pathVariables: state._sync.pathVariables
})
const fetched = state._sync.fetched[identifier]
// We've never fetched this before:
if (!fetched) {
Expand Down
6 changes: 5 additions & 1 deletion test/helpers/index.cjs.js
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,11 @@ function pluginActions (Firebase) {
}
if (!getters.signedIn)
return resolve();
var identifier = createFetchIdentifier({ where: where, orderBy: orderBy });
var identifier = createFetchIdentifier({
where: where,
orderBy: orderBy,
pathVariables: state._sync.pathVariables
});
var fetched = state._sync.fetched[identifier];
// We've never fetched this before:
if (!fetched) {
Expand Down

0 comments on commit 30f4c87

Please sign in to comment.