-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check-version-bump workflow #72
base: main
Are you sure you want to change the base?
Conversation
@jcbhmr I wonder if we should still merge this. I came to the realisation: adding
The fact that it won't publish from my local machine means the github action now succeeds. So I think that covers my automation wishes? Not sure if we need to force PR authors to bump their own package in this case. : ) What do you think? |
I still think warning (it doesn't block the merge) with a ❌ since you didn't bump the version is a Good Idea™. This is like a very basic version of "semantic release" workflow that doesn't incur any overhead like requiring labels on PRs like "major" and doesn't require "feat(thing): did thing"-style commit conventions. It's just a light "you should change the package.json version if you touch src/ stuff" workflow TLDR: I think that this is still a good thing to merge because it stops silly "forgor version bump 😜" commits AND forces PR authors to consciously think "what kind of change is this?" |
branches: 'production' | ||
paths: | ||
- src/** | ||
- test/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be here? 🤔 Do test changes require version bumps? Maybe not...
fixes #40
This PR would...